search

gokrazy / tools

this repository contains the gok CLI tool of gokrazy
https://gokrazy.org
BSD 3-Clause "New" or "Revised" License
50 stars 26 forks source link

gokr-packer: validate certificate matches key #34

Closed joneskoo closed 2 years ago

joneskoo commented 2 years ago

Fixes gokrazy/gokrazy#130.

stapelberg commented 2 years ago

This change makes the CI fail — could you take a look at that please?

joneskoo commented 2 years ago 
[building (go compiler)]
[65](https://github.com/gokrazy/tools/pull/34/checks#step:5:65)
[done] in 26.71s                        
[66](https://github.com/gokrazy/tools/pull/34/checks#step:5:66)
2022/05/01 11:07:28 Adding loadable kernel modules from modulesDir=/home/runner/go/pkg/mod/github.com/gokrazy/kernel@v0.0.0-20220428074446-79ddc444cba0/lib/modules
[67](https://github.com/gokrazy/tools/pull/34/checks#step:5:67)
2022/05/01 11:07:28 open : no such file or directory
[68](https://github.com/gokrazy/tools/pull/34/checks#step:5:68)

I don't know what it's trying to open.

Tests pass on my machine and I was able to use gokr-packer built with the change and it errored as expected with mismatched key/cert.

Any clues?

joneskoo commented 2 years ago

Oh is it when there's no -tls.. I didn't test that locally.