goksan
commented
2 months ago I think especially since the addition of the text based config it would be good to allow custom values, I'll take a look at this 👍
Open addvanced opened 2 months ago
goksan
commented
2 months ago I think especially since the addition of the text based config it would be good to allow custom values, I'll take a look at this 👍
As of right now, we have the predefined 10/30/60 seconds frequency, 5/10/15 seconds timeout and 1-3 attempts.
It would be nice to be able to have a bit more control over these values. So a suggestion could be:
Under each setting (frequency, timeout and attempt(s)), you could but an input field (numeric values, minimum 1) and a dropdown with the options: ms, sec, min
Under attempts, it should (of course) only be a number >= 1.
This would make it much easier to adjust the monitor to your specific URL. Maybe it's a service, and you want to have a timeout below 500ms.. or it's a service that for some reason might take more than 15 seconds to do some processing in the background, and you want it to respond in less than 30 seconds.
Just stick to the different time durations in Go (time.Millisecond, time.Second, time.Minute), so you could easily do something like: monitor.timeoutValue (of type int32) * monitor.timeoutDuration (of type time.Duration)