search

gokulgovind / GLNotificationBar

GLNotificationBar is a ios10 style notification bar, can be used to handle push notification in active state.
MIT License
301 stars 44 forks source link

Support for swift 3.0 #1

Closed paresh-navadiya closed 7 years ago

paresh-navadiya commented 7 years ago

Thanks for wonderful library

My concern was is there any support for swift 3.0 because its has become compulsory to update to swift 3.0 in coming days.

zammitjames commented 7 years ago

Yep, was about to open the same issue! Swift 3 is a must unfortunately, and this library seems too awesome to miss out on!

gokulgovind commented 7 years ago

Sure guys ASAP it'll will be updated with Swift 3.

zammitjames commented 7 years ago

@paresh-navadiya @gokulgovind forked and updated the main GLNotificationBar.swift to SWIFT 3, feel free to take it from here: https://github.com/zammitjames/GLNotificationBar/tree/master/GLNotificationBar

gokulgovind commented 7 years ago

@zammitjames thank you :) , will be updated soon.

zammitjames commented 7 years ago

@gokulgovind no prob! Great library :)

Rashesh-Bosamiya commented 7 years ago

why notification title and body coming as Optional("some text")?

gokulgovind commented 7 years ago

@Rashesh-Bosamiya those strings may be unwrapped, will be addressed soon.

Rashesh-Bosamiya commented 7 years ago

Means, are you gonna upload new version for this library?

ghost commented 7 years ago

@Rashesh-Bosamiya did you find any solutions to the the optional tile and body

gokulgovind commented 7 years ago

@pprevalon Check CalebeNP's comment on Closed issue,

to "fix" this you just have to make this change:

Before: fileprivate func setUpNotificationBar( header:String!, body:String!, notificationStyle:GLNotificationStyle) After: fileprivate func setUpNotificationBar( header:String, body:String, notificationStyle:GLNotificationStyle)