gokulgovind / GLNotificationBar

GLNotificationBar is a ios10 style notification bar, can be used to handle push notification in active state.
MIT License
301 stars 44 forks source link

Apple style, including shadow #14

Closed CavalcanteLeo closed 6 years ago

CavalcanteLeo commented 7 years ago

I've seen some layout differences between apple style and GLNotificationBar.

Mostly is because of the missing shadow, where it doesn't show legible the notificationBar.

I've changed to the apple's look and feel, but for that, i needed to remove the UIVisualEffect. On the screenshot, the layout seems a bit different yet, like spaces, sizes and even bg colors, but it's only to show how it works with shadow.

I can submit a PR for that, but remember, it doesn't work well with UIVisualEffect

styles

Shall i go further and change all look and feel to look exactly the same as apple, or leave like that? The bad thing is that the current banner is not readable with white layouts like mine.

You can try the diference using here:

pod 'GLNotificationBar', :git => 'git@github.com:CavalcanteLeo/GLNotificationBar.git', :branch => 'shadow'

and include setShadow true on the project

CavalcanteLeo commented 7 years ago

Here's how it looks with all colors variants

colors

gokulgovind commented 7 years ago

@CavalcanteLeo thanks for your initiative.

For now let it be like this ,Is that possible to add shadow to visual effect view ?. If so, no need to do major changes right.

CavalcanteLeo commented 7 years ago

Its not possible to add shadows on visual effect, i added a transparent uiview behind, and when active the shadow, i change the color to white

In fact, you can add shadow to UIVisualEffect, but as the view is half transparent, the shadow will appear inside too, looking terrible

CavalcanteLeo commented 7 years ago

PR: https://github.com/gokulgovind/GLNotificationBar/pull/15

CavalcanteLeo commented 6 years ago

Any news about it?

it's quite ugly and ineligible without shadow

azhararmar commented 6 years ago

Agreed, It is nice to have the shadow. It does look odd without the shadow.

gokulgovind commented 6 years ago

Hi @CavalcanteLeo ,

Nice to see you back, Sorry for the delay actually i was busy with my work. Now i have merged your pull request. Please check it.

Nice work work 👍 , Thank for your PR. :)

Soon i'll push next version with other issues fixed.

Thanks

CavalcanteLeo commented 6 years ago

great, thank you, dude!