search

gokulgovind / GLNotificationBar

GLNotificationBar is a ios10 style notification bar, can be used to handle push notification in active state.
MIT License
302 stars 44 forks source link

Crash : when continuously showing notification bar and tapping anyone of them #6

Closed paresh-navadiya closed 6 years ago

paresh-navadiya commented 7 years ago

[NotificationBar didSelectmessage:]: unrecognized selector sent to instance'

Can anyone provide solution?

gokulgovind commented 7 years ago

Hai @paresh-navadiya , sorry for late response.I had checked many times, Unable to reproduce the issue. Can you explain the exact scenario.

rsimenok commented 7 years ago

@gokulgovind

If i set handler to nil and tap on notification i get crash, try it. [[GLNotificationBar alloc] initWithTitle:@"test" message:@"test" preferredStyle:0 handler:nil];

line 666 in GLNotificationBar.swift

messageDidSelect(true)

should be

if messageDidSelect != nil {
     messageDidSelect(true)
}
gokulgovind commented 7 years ago

@rsimenok thanks for the issue, sure it will b fixed soon :)

rsimenok commented 7 years ago

@gokulgovind Hello, how soon it will be fixed? Thank you :)

CavalcanteLeo commented 7 years ago

I've fixed it, it's in my changes of the shadow support, but still doing it(shadow, the bug is done). I will send a PR soon You can try it using:

pod 'GLNotificationBar', :git => 'git@github.com:CavalcanteLeo/GLNotificationBar.git', :branch => 'shadow'

CavalcanteLeo commented 7 years ago

PR sent

here: https://github.com/gokulgovind/GLNotificationBar/pull/15/files#diff-140f46f2cc91d7b88e9b901ff9dd2061R112

and here: https://github.com/gokulgovind/GLNotificationBar/pull/15/files#diff-140f46f2cc91d7b88e9b901ff9dd2061R715

gokulgovind commented 6 years ago

Hi @rsimenok @paresh-navadiya ,

Pull request has been merged. Please make sure if the issue has been fixed.

If't feel free to reopen the bug.

Thanks.