search

gokulkrishh / expense.fyi

Effortlessly track and manage expenses on-the-go with categorisation and logging.
https://expense.fyi
GNU Affero General Public License v3.0
647 stars 93 forks source link

bug: Toploader loads endlessly on CMD + click #100

Closed tomcru closed 9 months ago

tomcru commented 9 months ago

Toploader should not trigger on CMD + click or when clicking on external links.

I can PR this issue, I would replace the current package with a drop-in replacement & a much more up-to-date library: Holy Loader (this is my library) - keeping the original look 1:1, but removing the bugs.

gokulkrishh commented 9 months ago

Toploader should not trigger on CMD + click or when clicking on external links.

@tomcru Now that you mentioned it, I just noticed it 😅.

I can PR this issue, I would replace the current package with a drop-in replacement & a much more up-to-date library: Holy Loader (this is my library) - keeping the original look 1:1, but removing the bugs.

Yep, thats would be great. So holy loader is your own library eh. Nice.