Cart Functionality - Frontend & Backend - CRUD - Add Product , Delete Product, Quantity change.

gokulprathin8 / Jaisalmer-E-Commerce

A Full stack & Machine Learning based application Open-source E-Commerce Application for 1 Click-Store deploy. Covering all the basic functionality of a Online store, Jaisalmer E-Commerce offers superior feedback in the forms of graphs, user monitoring, administration and much more..

https://github.com/gokulprathin8/Jaisalmer-E-Commerce

27 stars 26 forks source link

Cart Functionality - Frontend & Backend - CRUD - Add Product , Delete Product, Quantity change. #11

Open gokulprathin8 opened 3 years ago

rohithmsr commented 3 years ago

May I take this issue?? @gokulprathin8

gokulprathin8 commented 3 years ago

Hi, @rohithmsr I am hereby assigning this issue to you. However, I appreciate more than 1 person working on this. If anyone else is interested. Please comment here,

rohithmsr commented 3 years ago

So let me work on Backend first

GVaruni19 commented 3 years ago

Yes, I would like to work on it!

gokulprathin8 commented 3 years ago

Yes, I would like to work on it!

Hi,

@GVaruni19, Thanks for your interest. You have been assigned the issue.

rohithmsr commented 3 years ago

The model ProductMeasurements doesn't store the units (like kg, km, inch etc). It stores only the magnitude in the database.

So my questions are:

1) Why not keep measurements fields in product itself? 2) Shall we use any alternative to django_measurements.MeasurementField ?

@gokulprathin8 @GVaruni19

gokulprathin8 commented 3 years ago

The model ProductMeasurements doesn't store the units (like kg, km, inch etc). It stores only the magnitude in the database.

So my questions are:

1) Why not keep measurements fields in product itself? 2) Shall we use any alternative to django_measurements.MeasurementField ?

@gokulprathin8 @GVaruni19

Product Management stores metrics like kg, inch etc.. to database. DO NOT merge this with Product.

Because, ProductMeasuremets should be a foreign key to the Product. In that way it is easy to compute net values, net order worth with correct dimensions

Django Dimensions helps us to seamlessly convert one metric to another without any additional code.

@rohithmsr

gokulprathin8 commented 3 years ago

@rohithmsr @GVaruni19

Just to make things clear. You can view these images. The way how they are stored in database and Admin look and feel.

rohithmsr commented 3 years ago

I already checked this through pgAdmin, but where are the units given ??, it has only selection details right?

@gokulprathin8

gokulprathin8 commented 3 years ago

I already checked this through pgAdmin, but where are the units given ??, it has only selection details right?

@gokulprathin8

@rohithmsr ,

Django Dimensions, in this case by default, takes the value in the smallest terms.

For example, for 1 Kg it stores the data as 1000 grams It stores it as MASS and defaults to grams.

@rohank2502 is there any issue with this implementation ?

rohithmsr commented 3 years ago

Made a pull request, Please use Postman for testing @gokulprathin8

gokulprathin8 commented 3 years ago

Hi @rohithmsr,

code will be reviewed shortly and merged to the main branch.

Thank you for the contribution #Level3

subhangi2731 commented 3 years ago

please assign me this