search

gokulprathin8 / Jaisalmer-E-Commerce

A Full stack & Machine Learning based application Open-source E-Commerce Application for 1 Click-Store deploy. Covering all the basic functionality of a Online store, Jaisalmer E-Commerce offers superior feedback in the forms of graphs, user monitoring, administration and much more..
https://github.com/gokulprathin8/Jaisalmer-E-Commerce
28 stars 26 forks source link

moving some code of index.js that belongs to redux into redux folder #34

Closed abhay27chauhan closed 3 years ago

abhay27chauhan commented 3 years ago

Is your feature request related to a problem? Please describe. i would suggest to move the code from line no. 11 to 22 into redux folder as it belongs to redux and so that index

Screenshot 2021-03-26 at 9 32 30 PM

Describe the solution you'd like i will putting code into store.js file inside the redux folder

abhay27chauhan commented 3 years ago

I am a participant of GSSOC21, so please let me know if this is a valid proposal

github-actions[bot] commented 3 years ago

Hi, Congragulations on raising your first issue. Looking forward for your amazing contributions !!!

gokulprathin8 commented 3 years ago

Hi @abhay27chauhan, as of now - We are following Flux Architecture, for contributors to understand the redux integration better we have decided to have our reducers and persistors integrate into the store at index.js, which makes it easy to understand.

https://scotch.io/tutorials/getting-to-know-flux-the-react-js-architecture