golang-cafe / job-board

Golang Cafe - Go job board with no recruiters and clear salary ranges
https://golang.cafe
BSD 3-Clause "New" or "Revised" License
208 stars 50 forks source link

[BUG] W3C validation fix validation v2 #109

Closed jemiluv8 closed 1 year ago

jemiluv8 commented 1 year ago

Fix html validation for the following pages

companies page https://validator.w3.org/nu/?doc=https%3A%2F%2Fgolang.cafe%2FCompanies-Using-Golang
developers page https://validator.w3.org/nu/?doc=https%3A%2F%2Fgolang.cafe%2FGolang-Developers
salary page https://validator.w3.org/nu/?doc=https%3A%2F%2Fgolang.cafe%2FGolang-Developer-Salary-Remote
job page https://validator.w3.org/nu/?doc=https%3A%2F%2Fgolang.cafe%2Fjob%2Fsenior-backend-golang-engineer-parser-digital-1681918591

There is one (on the job detail page) that I wasn't sure may be on production. But need assistance to fix it. The check below makes it conditional on whether there is a companyiconid or not.

(I assume there should be for valid companies so this may probably never happen in production?)

                {{ if .CompanyIconID }}
                    <h2>
                      <img width="60" height="60" src="/x/s/m/{{ .CompanyIconID }}?w=100&h=100" class="job-icon" alt="{{ .Company }} Logo" title="{{ .Company }} Logo">
                    </h2>
                {{ end }}

this happens when there is no

Screenshot 2023-04-24 at 5 02 10 PM
ghost commented 1 year ago

thank you @jemiluv8