search

golang-cafe / job-board

Golang Cafe - Go job board with no recruiters and clear salary ranges
https://golang.cafe
BSD 3-Clause "New" or "Revised" License
208 stars 50 forks source link

[BUG] remove https in email links when in local environment #88

Closed ghost closed 1 year ago

ghost commented 1 year ago

locally there are no emails being sent, the links are just printed out in the console. We can use the if s.cfg.Env == "dev" check to remove https on local domains when printing in console

ghost commented 1 year ago

/bounty $10

algora-pbc[bot] commented 1 year ago

💎 $10.00 bounty created by dm161 👉 To claim this bounty, submit a pull request that includes the text /claim #88 somewhere in its body 📝 To receive payouts, join Algora and complete the relevant onboarding steps 💵 Payment arrives in your account 2-5 days after the bounty is rewarded 💯 You keep 100% of the bounty award 🙏 Thank you for contributing to golang-cafe/job-board!

ohmpatel1997 commented 1 year ago

@dm161 i have taken this issue, but the description is not quite clear. When you say we want to add local check while printing in on console, I think its already present there. Not sure if i have understood it correctly?

ghost commented 1 year ago

there are some places where we hardcode https like here for example https://github.com/golang-cafe/job-board/blob/77b28b8c91be790ca724f311375b8ad38a7ee924/internal/handler/handlers.go#L167

ohmpatel1997 commented 1 year ago

got it, thanks

algora-pbc[bot] commented 1 year ago

💡 Vasanth-Korada submitted a pull request that claims the bounty. You can visit your org dashboard to reward. 👉 @Vasanth-Korada: To receive payouts, sign up on Algora, link your Github account and connect with Stripe on your dashboard.

Vasanth-Korada commented 1 year ago

@dm161 I have taken up this as per the discussion in Telegram Channel and fixed it.

PR: https://github.com/golang-cafe/job-board/pull/90

algora-pbc[bot] commented 1 year ago

🎉🎈 @Vasanth-Korada has been awarded $10.00! 🎈🎊