search

golang-fips / openssl

OpenSSL bindings for Go
MIT License
19 stars 12 forks source link

[dsa.go] paramPubKey and paramPrivKey is missing #180

Closed mertakman closed 3 weeks ago

mertakman commented 3 weeks ago

It’s likely that these parameters existed during the development stage but were accidentally deleted before the changes were pushed. As a result, the tests are failing, and the repository is giving errors during development since this change . Example failed test link: https://github.com/golang-fips/openssl/actions/runs/10839009404/job/30078471426

mertakman commented 3 weeks ago

@qmuntal I think you have an idea for possible fix.

qmuntal commented 3 weeks ago

Wops, thanks for creating this issue, the dsa PR branch was not up to date with v2 when it was merged so CI didn't spot those conflicts.

I've updated the v2 branch settings to require status checks to pass and also to be up do date before merging any PR into it:

image