golangci-lint: remove deprecated linter & fix lint - Githubissues

golang-migrate / migrate

Database migrations. CLI and Golang library.

Other

14.48k stars 1.34k forks source link

golangci-lint: remove deprecated linter & fix lint #1104

Closed Shion1305 closed 3 weeks ago

Shion1305 commented 3 weeks ago

Describe the Bug

When you run golangci-lint on this repository now, you'll get following errors.

Here is the problem...

This repository uses interfacer linter, which is now deprecated.
errcheck fails on these code... https://github.com/golang-migrate/migrate/blob/aa2dad421f4dc7c9948a0dc2512a30efe47767d2/internal/cli/main.go#L278 https://github.com/golang-migrate/migrate/blob/aa2dad421f4dc7c9948a0dc2512a30efe47767d2/internal/cli/main.go#L309

Steps to Reproduce

Just run the latest version of golangci-lint. You can also reproduce by rerunning CI again.

dhui commented 3 weeks ago

Not sure why github didn't auto-resolve this issue. It's fixed by https://github.com/golang-migrate/migrate/pull/1105