search

golang-migrate / migrate

Database migrations. CLI and Golang library.
Other
15.49k stars 1.41k forks source link

Support non-linear migrations #278

Open ywk253100 opened 5 years ago

ywk253100 commented 5 years ago

We maintains 2 versions of an application: v1.0 released with 10_schema.up.sql v2.0 released with 10_schema.up.sql and 20_schema.up.sql

We found a bug in v1.0 and fixed it by changing database schema, so we released v1.1 with 10_schema.up.sql and 11_schema.up.sql.

But when users trying to upgrade v1.1 to v2.0, we got the "file does not exist" error as there is no 11_schema.up.sql in release v2.0. How can we handle this? Does checking the existence of 11_schema.up.sql make sense?

dhui commented 5 years ago

Back-filling context from a related issue:

https://github.com/golang-migrate/migrate/issues/79#issuecomment-526019418:

Assuming you can detect when an upgrade occurs, you can either:

  1. Force the migration. e.g. set the last successful migration to 10_schema.up.sql before running the v2.0 migrations
  2. Apply an upgrade migration. e.g. a set of migrations that contains the last v1.1 migration, missing migration(s) and the first v2.0 migration.

Neither solution is great since (1) is dangerous if a failure occurs during the migration and (2) makes it hard to maintain migrations. Unfortunately, migrate isn't as sophisticated as git where you can merge branches of migrations. Currently, migrations are expected to be linear.

https://github.com/golang-migrate/migrate/issues/79#issuecomment-526436995:

Our solution for now is that for v1.x only releases with 10_schema.up.sql, any other changes in sub version are handled by our own logic

lkebin commented 5 years ago

Same problem.

Developer A create migration file on branch issue-a, version is:  20190813143726 Developer B create migration file on branch issue-b, version is: 20190828180746

Currently, if issue-b release before issue-a, the migration 20190813143726 will be ignored.

dhui commented 5 years ago

Same problem.

Developer A create migration file on branch issue-a, version is: 20190813143726 Developer B create migration file on branch issue-b, version is: 20190828180746

Currently, if issue-b release before issue-a, the migration 20190813143726 will be ignored.

This is not the same problem as this case can be caught and made linear before deploy/shipping. We don't have a fix for this in migrate yet but have potential solutions.

lkebin commented 5 years ago

@dhui Sorry, I just open many related issue pages. Should comment on 179.