search

golang-migrate / migrate

Database migrations. CLI and Golang library.
Other
15.49k stars 1.41k forks source link

Bump `clickhouse-go` to v2 #942

Open magurotuna opened 1 year ago

magurotuna commented 1 year ago

Is your feature request related to a problem? Please describe.

Currently clickhouse-go v1.4.3 is used as a backing client to connect to ClickHouse, although v1 is in maintenance mode and we are encouraged to switch to v2. https://github.com/golang-migrate/migrate/blob/691bc773cc0f8492431cefda5396bbc2e4eea63d/go.mod#L7

Describe the solution you'd like

Bump the version of clickhouse-go to v2

Describe alternatives you've considered N/A

Additional context

What would be concerning about updating to v2 is that it has a few breaking changes that will likely affect the users of golang-migrate as well. For example, connection_open_strategy was set to random in v1, whereas in_order in v2. In my opinion it doesn't matter much for us as the users of golang-migrate, though.

kluevandrew commented 10 months ago

Any news?

ribtoks commented 2 months ago

I'm hitting a problem where latest migrate binary simply does not work with ClickHouse 23.8.9. However, same code, but supplied with clickhouse-go-v2-created instance of sql.DB and passed as argument to .WithInstance() is working. So updating clickhouse-go to v2 would really help!