search

golang-ui / nuklear

This project provides Go bindings for nuklear.h — a small ANSI C GUI library.
https://github.com/vurtun/nuklear
MIT License
1.57k stars 98 forks source link

Make nk-android multi-abi & multi-target friendly #18

Closed jfcg closed 6 years ago

jfcg commented 7 years ago
jfcg commented 7 years ago

Hi @xlab, have you seen this PR ?

xlab commented 7 years ago

Sorry, week been tough and this PR requires pre-processing as I'd like to have that as a separate project (do not replace gles3 with gles2, etc). If you separate that out somehow, i'd merge rightaway

jfcg commented 7 years ago

how about now? with preprocessing, do you mean writing to Application.mk file?

xlab commented 7 years ago

@jfcg sorry by pre-processing I meant that this PR couldn't be merged right away, as it will alter the example, so I had to checkout into new branch, make the modifications (so emulator target won't collide with ARM device target at all), then merge it.

The problem with having lots of targets in a single makefile is there because these files are boilerplate, intended to be copied around and should be minimal as possible. Additional targets for x86 in ARM files not welcome for this reason.

I reviewed a3dca63, so my idea is to leave nk-android example as is, but add another cmd/nk-android-x86 that will consider x86 and emulator targets.

xlab commented 6 years ago

Sorry we're replacing the build process for android-go projects, thus this PR won't be merged as it is. I'll update with more news soon.