golang / appengine

Go App Engine packages
http://google.golang.org/appengine
Apache License 2.0
666 stars 208 forks source link

Adopt google.golang.org/protobuf #228

Open tlimoncelli opened 3 years ago

tlimoncelli commented 3 years ago

This project imports github.com/golang/protobuf which is obsolete. Are there plans to switch to google.golang.org/protobuf ?

firenessmax commented 3 years ago

i have problem with the same import, my organization uses a dependency vulnerability check and give me some issues. Captura de Pantalla 2021-03-30 a la(s) 19 25 07

Deleplace commented 1 year ago

We should reopen and address this in some way

jinglundong commented 1 year ago

https://github.com/golang/appengine/releases/tag/v2.0.4 includes https://github.com/golang/appengine/pull/314, which should have this fixed. Haven't verified it yet.

aimuz commented 1 year ago

Any progress on this issue?

jinglundong commented 1 year ago

https://github.com/golang/appengine/releases/tag/v2.0.4 should have this fixed. Could you share more details in case I missed anything?

aimuz commented 1 year ago

Ideally you should switch github.com/golang/protobuf to google.golang.org/protobuf

There is also code that is relying on this library github.com/golang/protobuf

https://github.com/golang/appengine/blob/a080531dcab843de8cd8a4156b7fa1e14ebd68da/user/user.go#L12

https://github.com/golang/appengine/blob/a080531dcab843de8cd8a4156b7fa1e14ebd68da/mail/mail.go#L27

jinglundong commented 1 year ago

ACK. I will try to share an update early next week. Sorry for not being able to stay on top of this issue.

jkroepke commented 9 months ago

@jinglundong do you have an update? Since the oauth2 package depends on appengine, the import of the deprecated package is spread across the half go universe (https://github.com/golang/oauth2/blob/master/go.mod)

trakhimenok commented 9 months ago

image

Can we get some update on when we can expect not to download & compile 2 versions of the same thing?

trakhimenok commented 4 months ago

Is anyone assigned to this?