search

golang / appengine

Go App Engine packages
http://google.golang.org/appengine
Apache License 2.0
671 stars 206 forks source link

Support http.request.Context() and http.request.WithContext() #66

Closed roseperrone closed 6 years ago

roseperrone commented 7 years ago

net/http.Request.Context() was added in Go 1.7, yet when I use api_version: go1.7 in my app.yaml, I still get this error:

type *http.Request has no field or method Context

floresj commented 7 years ago

Was this in the standard environment? If so, I think they're still on 1.6

broady commented 7 years ago

Correct, once we're on Go 1.7+, we should add this.

warent commented 7 years ago

This bug has caused much weeping and gnashing of teeth... Any ETA on when it will be resolved?

broady commented 7 years ago

Can't give an accurate timeline, sorry. Hoping for the order of a month or two.

On Tue, Aug 1, 2017 at 3:39 PM, Sarah Adams notifications@github.com wrote:

Assigned #66 https://github.com/golang/appengine/issues/66 to @broady https://github.com/broady.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/golang/appengine/issues/66#event-1188569680, or mute the thread https://github.com/notifications/unsubscribe-auth/AABhlljlW3CxTaiJgSS10KMW6tWjgvGDks5sT6kJgaJpZM4Mi54p .

zombiezen commented 6 years ago

Marking fixed.