search

golang / dep

Go dependency management tool experiment (deprecated)
https://golang.github.io/dep/
BSD 3-Clause "New" or "Revised" License
12.85k stars 1.05k forks source link

Ignored packages still keep preserved files. #2105

Closed rgaskill closed 4 years ago

rgaskill commented 5 years ago

What version of dep are you using (dep version)?

v0.5.0

What dep command did you run?

dep ensure

What did you expect to see?

I have specified an ignored package e.g. ignored = ["github.com/user/repo/ignoreme"] The package ignoreme tree contains the file copyright.js. I expect the entire ignoreme package structure to be pruned out of the vendor dir.

What did you see instead?

An empty package structure only containing the copyright.js file.

kevinburke commented 5 years ago

Do you have a public repo I can reproduce this on, or can you email one to me?

Basically you had a project in the vendor directory, then added it to ignored, and it didn't get removed?

rgaskill commented 5 years ago

I made this one to demonstrate the issue. https://github.com/rgaskill/testdep

After running dep ensure you will see the go file in the github.com/rgaskill/ignoreme/nothing package is excluded from the vendor directory but not the copyright.js file

mvdan commented 4 years ago

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!