golang / dep

Go dependency management tool experiment (deprecated)
https://golang.github.io/dep/
BSD 3-Clause "New" or "Revised" License
12.85k stars 1.05k forks source link

tip: tests fail #2115

Closed kevinburke closed 4 years ago

kevinburke commented 5 years ago

These are new. I haven't investigated at all.

--- FAIL: TestWorkmapToReach (0.00s)
    --- FAIL: TestWorkmapToReach/transitive_err'd_package_is_poison (0.00s)
        pkgtree_test.go:555: Did not get expected error map:
                (GOT): map[A:"A" transitively (through 1 packages) imports "A/bar", which contains malformed code: err pkg A/bar:"A/bar" contains malformed code: err pkg A/foo:"A/foo" imports "A/bar", which contains malformed code: err pkg]
                (WNT): map[A:"A" transitively (through 1 packages) imports "A/bar", which contains malformed code: err pkg A/bar:"A/bar" contains malformed code: err pkg A/foo:"A/foo" imports "A/bar", which contains malformed code: err pkg]
    --- FAIL: TestWorkmapToReach/transitive_missing_package_is_poison (0.00s)
        pkgtree_test.go:555: Did not get expected error map:
                (GOT): map[A:"A" transitively (through 1 packages) imports "A/bar", which contains malformed code: no package exists at "A/bar" A/foo:"A/foo" imports "A/bar", which contains malformed code: no package exists at "A/bar"]
                (WNT): map[A:"A" transitively (through 1 packages) imports "A/bar", which contains malformed code: no package exists at "A/bar" A/foo:"A/foo" imports "A/bar", which contains malformed code: no package exists at "A/bar"]

See also https://travis-ci.org/golang/dep/jobs/501321181 and https://github.com/golang/dep/pull/2114 - I believe this is the only failure blocking that PR.

kevinburke commented 5 years ago

I... don't see the difference there? Is this a reflect.DeepEqual thing?

mvdan commented 4 years ago

Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!