Closed moadqassem closed 3 years ago
Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks!
What version of
dep
are you using (dep version
)?What
dep
command did you run?dep ensure -update github.com/kubermatic/machine-controller
What did you expect to see?
I am expecting the passed dependency to be updated.
What did you see instead?
I am seeing a panic:
To be honest I am not quite sure if the panic occours, becuase the dependency which it tries to get has been already popped of the queue and the
getDependenciesOn
is expecting to find it. I am expecting this because there is no check for the[]dependency
slice. The current solution for this, is just check the[]dependency
slice first and then try to call thefail
method on it:I have opened a PR to fix the panic, however more investigation would be nice.