search

golang / dep

Go dependency management tool experiment (deprecated)
https://golang.github.io/dep/
BSD 3-Clause "New" or "Revised" License
12.87k stars 1.05k forks source link

README: clarify deprecation and point to modules #2253

Closed mvdan closed 3 years ago

mvdan commented 3 years ago

See https://github.com/golang/go/issues/38158.

mvdan commented 3 years ago

FYI @myitcv @ALTree; had to create a PR since the master branch is locked against direct pushes.

mvdan commented 3 years ago

Oh, the docs site is also in the master branch. I'll fix that here too.

mvdan commented 3 years ago

You both raise good points :) I'll update the commit.

Also, of course CI is required to merge, and it's broken... we'll have to wait for @andybons to grant one of us admin access to be able to push to master.

ALTree commented 3 years ago

Indeed, the build is broken, so I've just disabled the hard requirement on the travis-ci check for merges. Now it should allow the merge even if the travis-ci build failed.

mvdan commented 3 years ago

I ended up with **NOTE:** instead of ** NOTE: **, because only the former would actually render as bold. I love markdown sometimes.

mvdan commented 3 years ago

I think the Feedback and Contributing sections should be deleted from the README

I've also deleted both of those sections. Merging - thanks both for the reviews!

mvdan commented 3 years ago

It looks like actually updating the generated gh-pages branch is a manual process, last done in 2018. I'll try to figure out how to do it and push there.

mvdan commented 3 years ago

Alright, done: https://github.com/golang/dep/commit/7afd7b621aa961eab9807a54e66751313608cebc

All that I did boiled down to:

cd website
yarn
yarn build
GIT_USER=mvdan yarn publish-gh-pages

There are other changes applied to the generated pages aside from this PR, which I attribute to the long time it's been since anyone ran the tool. They all seem minor, though.