search

golang / freetype

The Freetype font rasterizer in the Go programming language.
Other
786 stars 184 forks source link

Support TTC v2 #47

Closed mattn closed 7 years ago

mattn commented 7 years ago

added test for parsing TTC but I don't include testdata.

Close #11

mattn commented 7 years ago

Sorry, NotoSansCJK-Black is not good for this test because this contains OTTO (Adobe OpenType OTTO). So it cause parse error. I'll try to find font for this.

mattn commented 7 years ago

updated. I copied TestTTC.ttc from fonttools project.

https://github.com/fonttools/fonttools/tree/master/Tests

nigeltao commented 7 years ago

I'm still not convinced that adding a .ttc file to testdata/ is really worth it. I'd just leave it out.

mattn commented 7 years ago

Do you prefer it is x-foo?

nigeltao commented 7 years ago

I prefer to leave it out.

mattn commented 7 years ago

you mean it's okay without test, right?

nigeltao commented 7 years ago

Yes, OK without test.

mattn commented 7 years ago

please take a look.

nigeltao commented 7 years ago

Thanks for your patience.