search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 265 forks source link

Local build fails #499

Open kevinburke opened 7 years ago

kevinburke commented 7 years ago

I'm compiling Go using tip on a Mac - go version devel +e9b9dfe3f7 Tue Jul 18 04:42:09 2017 +0000 darwin/amd64.

I get the following errors when I clone the project and run go install -v ./...

$ go install -v ./...
github.com/golang/gddo/gddo-admin
github.com/golang/gddo/gae-service-proxy
# github.com/golang/gddo/gddo-admin
gddo-admin/block.go:26:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
gddo-admin/crawl.go:31:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
gddo-admin/dangle.go:29:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
gddo-admin/delete.go:27:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
gddo-admin/popular.go:33:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
gddo-admin/reindex.go:54:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
gddo-admin/stats.go:40:25: not enough arguments in call to database.New
    have ()
    want (string, time.Duration, bool, string)
# github.com/golang/gddo/gae-service-proxy
runtime.main_main·f: relocation target main.main not defined
runtime.main_main·f: undefined: "main.main"
kevinburke commented 7 years ago

Is anyone still using gddo-admin? The code seems pretty broken and has been since March: https://go.googlesource.com/gddo/+/6e5c160ff3caae4d01d4fb8c89444c6de8314b23

I could copy the approach taken by gddo-server to read the database values, but that would require porting the flags from each command subset in gddo-admin to use pflag, and then adding the database flags to each one.

shantuo commented 7 years ago

This related to the recent change on the database package, see CL. The reason is that gddo was running on App Engine Managed VMs and we needed to migrate it to Flex since the previous one is deprecated. I plan to work on it to fix the broken local dev.

gddo-admin isn't useful for the production setup I run.

gae-service-proxy is an App Engine Standard app used for accessing search API through remote_api @stephenmw do you know how to run that locally?