search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 265 forks source link

talks.godoc.org still links to go-talks.appspot.com #532

Closed mvdan closed 6 years ago

mvdan commented 6 years ago

The syntax for URLs is: http://go-talks.appspot.com/github.com/owner/project/file.ext http://go-talks.appspot.com/github.com/owner/project/sub/directory/file.ext

I realise that both work, but talks.godoc.org is more likely to survive in the long term and it's a better URL to suggest to users.

mvdan commented 6 years ago

Alternatively, I'm sure there would be a way to make the template use whatever domain it's being served on.

leighmcculloch commented 6 years ago

Gerrit doesn't seem to cross post, but I opened a fix for this here: https://go-review.googlesource.com/#/c/gddo/+/95256

While I think that it might be nice to display whatever the hostname is, it's simpler and less logic to simply update the domain with the canonical location.

dmitshur commented 6 years ago

Reopening for tracking when the fix has been deployed. /cc @shantuo

shantuo commented 6 years ago

Deployed now.