search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 266 forks source link

Talks doesn't support .background #541

Closed nezorflame closed 5 years ago

nezorflame commented 6 years ago

Host any present slide with .background image. It won't be shown for your presentation. Other images seem to work fine.

Is this a bug or feature?

dmitshur commented 6 years ago

Is this an issue with the present command? Or just talks.godoc.org?

nezorflame commented 6 years ago

Just talks.godoc.org

nezorflame commented 6 years ago

Background works fine when present is launched locally.

mmcloughlin commented 6 years ago

I'm seeing this too. There seems to be some re-processing of presentations happening which is not re-mapping .background URLs to point at github instead. See

https://github.com/golang/gddo/blob/9d8ff1c67be5c2da6321c656913e1fe355991138/gosrc/present.go#L37-L39

Looks like this would not be too hard to fix.

mmcloughlin commented 6 years ago

See https://go-review.googlesource.com/c/gddo/+/133235

dmitshur commented 6 years ago

@nezorflame (or anyone else), do you know of a sample talk that has a slide with .background that can be used to reproduce the bug?

nezorflame commented 6 years ago

@dmitshur sure, take mine: https://talks.godoc.org/github.com/nezorflame/golang-talks/2018/05/execution-tracing-in-go1.11/main.slide#1

Source for it: https://github.com/nezorflame/golang-talks/tree/master/2018/05/execution-tracing-in-go1.11

mmcloughlin commented 5 years ago

Any thoughts on the CL https://go-review.googlesource.com/c/gddo/+/133235 ?

Deleplace commented 5 years ago

@mmcloughlin I read it and tested it locally, everything works fine on my workstation.

dmitshur commented 5 years ago

The new version is deployed now, so .background should be working. Thank you for the contribution!

Deleplace commented 5 years ago

Thank you @dmitshur . It now works fine on the public URL of my slideshow.

mmcloughlin commented 5 years ago

We can also test this with the sample presentation that was also included in the CL. This was intended to exercise all possible features of the present tool.

https://talks.godoc.org/github.com/golang/gddo/gosrc/testdata/sample.slide

We do indeed see the .background correctly, however it seems the the vector graphic is broken.

mmcloughlin commented 5 years ago

I'm getting a 403 from https://rawgit.com/golang/gddo/master/gosrc/testdata/gopher.svg

https://rawgit.com says "RawGit has reached the end of its useful life".