search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 266 forks source link

gddo-server: log configuration settings as Debug only #545

Closed parkr closed 6 years ago

parkr commented 6 years ago

To prevent leaking sensitive data in the normal case, use the Debug logging level instead of Info when logging credentials.

There are very sensitive pieces of data in the settings, namely GitHub secrets, Redis database passwords, etc. In the normal case, these are logged. To prevent accidental leaking of credentials, only print settings map when logging in Debug mode.

parkr commented 6 years ago

I was expecting this to create a CL in Gerritt for me – holler if I need to do some finagling of that myself. This was just faster for me :)

gopherbot commented 6 years ago

This PR (HEAD: 70b36f748181c76ec74a3629d4375a64e2d5a128) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/#/c/gddo/+/102278 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 6 years ago

Message from Parker Moore:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/102278. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

Message from Tuo Shan:

Patch Set 1: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/102278. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

This PR is being closed because golang.org/cl/102278 has been merged.

parkr commented 6 years ago

Thank you!