Open AlphaWong opened 6 years ago
Message from Gobot Gobot:
Patch Set 1:
Congratulations on opening your first change. Thank you for your contribution!
Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.
Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.
During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.
Please don’t reply on this GitHub thread. Visit golang.org/cl/122195. After addressing review feedback, remember to publish your drafts!
Message from Akhil Indurti:
Patch Set 4:
(2 comments)
Please don’t reply on this GitHub thread. Visit golang.org/cl/122195. After addressing review feedback, remember to publish your drafts!
Message from Alpha WONG:
Patch Set 5:
Patch Set 4:
(2 comments)
I change it according to your review
Please don’t reply on this GitHub thread. Visit golang.org/cl/122195. After addressing review feedback, remember to publish your drafts!
Message from Akhil Indurti:
Patch Set 6:
(2 comments)
LGTM, but I haven't reviewed for godoc.org before so I'll ping Brad.
Please don’t reply on this GitHub thread. Visit golang.org/cl/122195. After addressing review feedback, remember to publish your drafts!
Message from Alpha WONG:
Patch Set 6:
Patch Set 6:
(2 comments)
LGTM, but I haven't reviewed for godoc.org before so I'll ping Brad.
Sure, let me clear it up. thx
Please don’t reply on this GitHub thread. Visit golang.org/cl/122195. After addressing review feedback, remember to publish your drafts!
Message from Gerrit User 24958:
Patch Set 7:
(1 comment)
Please don’t reply on this GitHub thread. Visit golang.org/cl/122195. After addressing review feedback, remember to publish your drafts!
ADD HSTS header to godoc.org
Please review my changes
Related
https://github.com/golang/go/issues/26162