search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 266 forks source link

gosrc: add missing context parameters to print.go #577

Closed arp242 closed 6 years ago

arp242 commented 6 years ago

Support for the context package was added in baa18d8, but the gosrc/print.go debug utility was never updated, and since it has the ignore build tag go test etc. didn't catch this.

This will not affect godoc.org operation; it's just a debug utility for developers; it was helpful for me in examining #576.

gopherbot commented 6 years ago

Message from Gerrit User 6005:

Patch Set 1: Code-Review+2

(1 comment)

Please fix the commit message title (by editing the PR title, per https://golang.org/wiki/GerritBot#how-does-gerritbot-determine-the-final-commit-message). Otherwise LGTM. Thanks!

Please don’t reply on this GitHub thread. Visit golang.org/cl/132655. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/132655. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

This PR is being closed because golang.org/cl/132655 has been merged.