search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 265 forks source link

gddo-server: fix expanding examples containing reserved characters #581

Closed jackwilsdon closed 1 year ago

jackwilsdon commented 6 years ago

The href attribute is percent-encoded by html/template, which ends up breaking how Bootstrap links the heading to it's target. We can instead use data-target to explicitly name the target, without it being percent-encoded.

Fixes #570

gopherbot commented 6 years ago

This PR (HEAD: 340e2d42473322fce975433635566da486eb5db0) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 6 years ago

Message from Gerrit User 5976:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135536. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

This PR (HEAD: dfc65a6d04872f572f585cb37de235aa81073967) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 6 years ago

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135536. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

This PR (HEAD: 7372e7085c7148dd140b3894e4dc5ac98d4b7473) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135536 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 6 years ago

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135536. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135536. After addressing review feedback, remember to publish your drafts!

gopherbot commented 6 years ago

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135536. After addressing review feedback, remember to publish your drafts!