search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 266 forks source link

gddo-server: simplify onclick listener for example list #582

Closed jackwilsdon closed 1 year ago

jackwilsdon commented 5 years ago

Bootstrap already provides a collapse method which allows us to expand a specific element, meaning we don't have to manage the element's classes and height ourselves.

gopherbot commented 5 years ago

This PR (HEAD: 6dcdeb54e116ea55b13bd0eae8a3d44325e94a1a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135537 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

This PR (HEAD: 19601ca08b31db8a2a0f5ebf6f66e7a79df1c555) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135537 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Gerrit User 12446:

Uploaded patch set 2: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135537. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Gerrit User 12446:

Uploaded patch set 3: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135537. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

This PR (HEAD: bb02266c001bc94ec1a6a61ae0993c1bbfed4726) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/135537 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Gerrit User 12446:

Uploaded patch set 4: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135537. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Gerrit User 12446:

Uploaded patch set 5: Commit message was updated.

Please don’t reply on this GitHub thread. Visit golang.org/cl/135537. After addressing review feedback, remember to publish your drafts!