search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 266 forks source link

gosrc: svg files in presentations not displayed properly #587

Open mmcloughlin opened 5 years ago

mmcloughlin commented 5 years ago

svg images are not displayed properly on talks.godoc.org, for example:

https://talks.godoc.org/github.com/golang/gddo/gosrc/testdata/sample.slide#5

svg images are repointed at https://rawgit.com/

https://github.com/golang/gddo/blob/9d8ff1c67be5c2da6321c656913e1fe355991138/gosrc/github.go#L245

According to their website "RawGit has reached the end of its useful life", hence the request is returning with a 403.

This is a simple fix if we can find another service for serving up the files.

mmcloughlin commented 5 years ago

Some alternatives:

https://raw.githack.com/golang/gddo/master/gosrc/testdata/gopher.svg https://gitcdn.link/repo/golang/gddo/master/gosrc/testdata/gopher.svg

mmcloughlin commented 5 years ago

See https://go-review.googlesource.com/c/gddo/+/140918

Aside, why is gobot not enabled for this repo, to automatically link issues with CLs?

dmitshur commented 5 years ago

Aside, why is gobot not enabled for this repo, to automatically link issues with CLs?

Right now, only CLs that mention issues in the main Go issue tracker are enabled. See here. Please open an issue in the main tracker if you think we should change that.