search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 266 forks source link

Move to Go modules #621

Closed freeformz closed 3 years ago

freeformz commented 5 years ago

This is the result of: go mod init github.com/golang/gddo go mod tidy

gopherbot commented 5 years ago

This PR (HEAD: e6333b6bb327706c6674952f94158811489e6e2a) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Gobot Gobot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

This PR (HEAD: 455226cac84fd87097bd554eb94887c703bc0333) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

This PR (HEAD: 9705b3bb8ef7964f98011af1b4007c18324d9af2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Bryan C. Mills:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Gobot Gobot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c24a64a

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Gobot Gobot:

Patch Set 3:

Build is still in progress... This change failed on freebsd-amd64-12_0: See https://storage.googleapis.com/go-build-log/d307bd4e/freebsd-amd64-12_0_dc69aee3.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Gobot Gobot:

Patch Set 3: TryBot-Result-1

9 of 9 TryBots failed: Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/d307bd4e/freebsd-amd64-12_0_dc69aee3.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/d307bd4e/openbsd-amd64-64_73d6b975.log Failed on linux-386: https://storage.googleapis.com/go-build-log/d307bd4e/linux-386_094f2dd9.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/d307bd4e/linux-amd64_7ca11bfa.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/d307bd4e/linux-amd64-race_742fec58.log Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/afcfe0d3/linux-amd64_ff5e55d7.log Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/efa061d9/linux-amd64_49b5b176.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/d307bd4e/windows-amd64-2016_95b3f48e.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/d307bd4e/windows-386-2008_f92b3cc8.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

This PR (HEAD: 09775ed6c5d35169078bbf3f5737381969bc4f86) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

This PR (HEAD: dbe150e12ef6cd1ff5b753543cfbc7f980f98c10) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

This PR (HEAD: a44a4ad554bfab19049bd6683fb70f7844d95930) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Colin Arnott:

Patch Set 6:

This duplicates CL 168066.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Bryan C. Mills:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

That suggests that the tests need some sort of update, since AppEngine claims to support modules: https://cloud.google.com/blog/products/application-development/go-1-11-is-now-available-on-app-engine

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 6:

Patch Set 6:

This duplicates CL 168066.

168066 seems less complete than this one.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

That suggests that the tests need some sort of update, since AppEngine claims to support modules: https://cloud.google.com/blog/products/application-development/go-1-11-is-now-available-on-app-engine

AFAICT it's related to how the goapp command works, which I know nothing about. But I'll poke at it.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

This PR (HEAD: df105843f7841003e00feb7d986f5831a8710de4) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

This PR (HEAD: 14b855d50481265cd19bad83f109318ffa77440e) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/178597 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 8:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

That suggests that the tests need some sort of update, since AppEngine claims to support modules: https://cloud.google.com/blog/products/application-development/go-1-11-is-now-available-on-app-engine

AFAICT it's related to how the goapp command works, which I know nothing about. But I'll poke at it.

goapp is apparently deprecated as well.

The original App Engine SDK is superseded by the Cloud SDK and its gcloud commands. If your systems or scripts rely on the appcfg or goapp commands, you can download and install the original App Engine SDK by following the instructions below.

Via https://cloud.google.com/appengine/docs/standard/go/download

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 8:

Patch Set 8:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

That suggests that the tests need some sort of update, since AppEngine claims to support modules: https://cloud.google.com/blog/products/application-development/go-1-11-is-now-available-on-app-engine

AFAICT it's related to how the goapp command works, which I know nothing about. But I'll poke at it.

goapp is apparently deprecated as well.

The original App Engine SDK is superseded by the Cloud SDK and its gcloud commands. If your systems or scripts rely on the appcfg or goapp commands, you can download and install the original App Engine SDK by following the instructions below.

Via https://cloud.google.com/appengine/docs/standard/go/download

AFAICT goapp is go v1.9.X

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 8:

Patch Set 8:

Patch Set 8:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

That suggests that the tests need some sort of update, since AppEngine claims to support modules: https://cloud.google.com/blog/products/application-development/go-1-11-is-now-available-on-app-engine

AFAICT it's related to how the goapp command works, which I know nothing about. But I'll poke at it.

goapp is apparently deprecated as well.

The original App Engine SDK is superseded by the Cloud SDK and its gcloud commands. If your systems or scripts rely on the appcfg or goapp commands, you can download and install the original App Engine SDK by following the instructions below.

Via https://cloud.google.com/appengine/docs/standard/go/download

AFAICT goapp is go v1.9.X

After looking into this a little more my suggestion is to vendor for now, and have a follow on CL to move talksapp to go1.12 / newer GAE runtime, which should have the side effect of removing the need to vendor.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 8:

Patch Set 8:

Patch Set 8:

Patch Set 8:

Patch Set 6:

Patch Set 6:

Patch Set 6:

(1 comment)

Patch Set 4:

Patch Set 3: Run-TryBot+1 Code-Review+1

(1 comment)

I'm not sure if it's needed or not. Internally I'm still recommending people vendor stuff until at least go1.13, but likely go1.14 is released to avoid random issues when possible.

I'll remove the vendor directory to see what breaks.

The talksapp tests fail without the vendor directory: https://travis-ci.org/golang/gddo/jobs/536022061

That suggests that the tests need some sort of update, since AppEngine claims to support modules: https://cloud.google.com/blog/products/application-development/go-1-11-is-now-available-on-app-engine

AFAICT it's related to how the goapp command works, which I know nothing about. But I'll poke at it.

goapp is apparently deprecated as well.

The original App Engine SDK is superseded by the Cloud SDK and its gcloud commands. If your systems or scripts rely on the appcfg or goapp commands, you can download and install the original App Engine SDK by following the instructions below.

Via https://cloud.google.com/appengine/docs/standard/go/download

AFAICT goapp is go v1.9.X

After looking into this a little more my suggestion is to vendor for now, and have a follow on CL to move talksapp to go1.12 / newer GAE runtime, which should have the side effect of removing the need to vendor.

For context, this is why: https://cloud.google.com/appengine/docs/standard/go112/go-differences

It's a much bigger change (and likely one for the good).

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Edward Muller:

Patch Set 8:

BUMP. Any thoughts?

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 5 years ago

Message from Bryan C. Mills:

Patch Set 8:

(2 comments)

Patch Set 8:

BUMP. Any thoughts?

Mostly I want to leave this up to Dmitri: I'm not particularly familiar with this code, and it seems like there is a lot of appengine legacy here.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

dmitris commented 5 years ago

@freeformz - does your change need to be rebased? Since it's almost a month since the last activity on https://go-review.googlesource.com/c/gddo/+/178597, I sent another shot to add go.mod in https://go-review.googlesource.com/c/gddo/+/187717 - hopefully either one or another can resolve this in a near future 😄

gopherbot commented 3 years ago

Message from Go Bot:

Patch Set 1:

Congratulations on opening your first change. Thank you for your contribution!

Next steps: Within the next week or so, a maintainer will review your change and provide feedback. See https://golang.org/doc/contribute.html#review for more info and tips to get your patch through code review.

Most changes in the Go project go through a few rounds of revision. This can be surprising to people new to the project. The careful, iterative review process is our way of helping mentor contributors and ensuring that their contributions have a lasting impact.

During May-July and Nov-Jan the Go project is in a code freeze, during which little code gets reviewed or merged. If a reviewer responds with a comment like R=go1.11, it means that this CL will be reviewed as part of the next development cycle. See https://golang.org/s/release for more details.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 3 years ago

Message from Go Bot:

Patch Set 3:

TryBots beginning. Status page: https://farmer.golang.org/try?commit=2c24a64a

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 3 years ago

Message from Go Bot:

Patch Set 3:

Build is still in progress... This change failed on freebsd-amd64-12_0: See https://storage.googleapis.com/go-build-log/d307bd4e/freebsd-amd64-12_0_dc69aee3.log

Other builds still in progress; subsequent failure notices suppressed until final report. Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 3 years ago

Message from Go Bot:

Patch Set 3: TryBot-Result-1

9 of 9 TryBots failed: Failed on freebsd-amd64-12_0: https://storage.googleapis.com/go-build-log/d307bd4e/freebsd-amd64-12_0_dc69aee3.log Failed on openbsd-amd64-64: https://storage.googleapis.com/go-build-log/d307bd4e/openbsd-amd64-64_73d6b975.log Failed on linux-386: https://storage.googleapis.com/go-build-log/d307bd4e/linux-386_094f2dd9.log Failed on linux-amd64: https://storage.googleapis.com/go-build-log/d307bd4e/linux-amd64_7ca11bfa.log Failed on linux-amd64-race: https://storage.googleapis.com/go-build-log/d307bd4e/linux-amd64-race_742fec58.log Failed on linux-amd64 (Go 1.12.x): https://storage.googleapis.com/go-build-log/afcfe0d3/linux-amd64_ff5e55d7.log Failed on linux-amd64 (Go 1.11.x): https://storage.googleapis.com/go-build-log/efa061d9/linux-amd64_49b5b176.log Failed on windows-amd64-2016: https://storage.googleapis.com/go-build-log/d307bd4e/windows-amd64-2016_95b3f48e.log Failed on windows-386-2008: https://storage.googleapis.com/go-build-log/d307bd4e/windows-386-2008_f92b3cc8.log

Consult https://build.golang.org/ to see whether they are new failures. Keep in mind that TryBots currently test exactly your git commit, without rebasing. If your commit's git parent is old, the failure might've already been fixed.

Please don’t reply on this GitHub thread. Visit golang.org/cl/178597. After addressing review feedback, remember to publish your drafts!

gopherbot commented 3 years ago

This PR is being closed because golang.org/cl/178597 has been abandoned.

Thanks for sending this change. A similar change was made via https://golang.org/cl/215678, so closing.