search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 265 forks source link

feat(gddo-server): make log level configurable, default to info #660

Open dominicbarnes opened 5 years ago

dominicbarnes commented 5 years ago

This PR adds the ability to configure the log level for the server. Currently, the default is to log everything (including debug) which logs secrets like the github token and is a security risk.

This is similar to #554 but opts to integrate with viper to keep this consistent, in addition to allowing this to be set as a CLI flag.

Lastly, the default log level becomes "info" which is probably what most people want, and they can opt in to "debug" if needed when troubleshooting.

gopherbot commented 5 years ago

This PR (HEAD: f68fa17345303f1aa978069cbe7b665e1cb1cd1b) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/205607 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

This PR (HEAD: 1ed333ac9f42f921d08fc194caffa433a63c75f7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/205607 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info

gopherbot commented 5 years ago

This PR (HEAD: b36045e475d02e1dc208e0e3b029876e73638e57) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/gddo/+/205607 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off) See the Wiki page for more info