search

golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 265 forks source link

Wrong instruction in Rate Limiting #674

Open njh7799 opened 4 years ago

njh7799 commented 4 years ago

There is a wrong instruction in here.
Quote of TotalTime and TotalCPUTime are interchanged.

type RateLimiting struct {
    CallCount                   int    `json:"call_count"`                      // Percentage of calls made for this business ad account.
    TotalTime                   int    `json:"total_time"`                      // Percentage of the total CPU time that has been used.
    TotalCPUTime                int    `json:"total_cputime"`                   // Percentage of the total time that has been used.
    Type                        string `json:"type"`                            // Type of rate limit logic being applied.
    EstimatedTimeToRegainAccess int    `json:"estimated_time_to_regain_access"` // Time in minutes to resume calls.
}

must be 

type RateLimiting struct {
    CallCount                   int    `json:"call_count"`                      // Percentage of calls made for this business ad account.
    TotalTime                   int    `json:"total_time"`                      // Percentage of the total time that has been used.
    TotalCPUTime                int    `json:"total_cputime"`                   // Percentage of the total CPU time that has been used.
    Type                        string `json:"type"`                            // Type of rate limit logic being applied.
    EstimatedTimeToRegainAccess int    `json:"estimated_time_to_regain_access"` // Time in minutes to resume calls.
}
jackwilsdon commented 4 years ago

This is an issue with https://github.com/huandu/facebook, this repository is the source for godoc.org itself, not the packages documented by it.