golang / gddo

Go Doc Dot Org
https://godoc.org
BSD 3-Clause "New" or "Revised" License
1.1k stars 267 forks source link

GoDoc.org shows out of date package github:temporalio/temporal-go-sdk #688

Closed flossypurse closed 3 years ago

flossypurse commented 3 years ago

What is the URL of the page with the issue?

https://godoc.org/github.com/temporalio/temporal-go-sdk

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/84.0.4147.135 Safari/537.36

Screenshot

Screen Shot 2020-09-03 at 2 31 52 PM

What did you do?

Searched for "temporal go sdk"

What did you expect to see?

The up-to-date package github.com:temporalio/go-sdk The up-to-date package is available via pkg.go.dev: https://pkg.go.dev/go.temporal.io/sdk

What did you see instead?

This package no longer exists (github.com:temporalio/temporal-go-sdk) We don't want the old out-of-date package to be published.

dmitshur commented 3 years ago

The repository at https://github.com/temporalio/temporal-go-sdk exists.

The problem here is that godoc.org is not module aware, so it doesn't know to read the go.mod file, where it's stated that the canonical import path is go.temporal.io/sdk rather than github.com/temporalio/temporal-go-sdk.

/cc @julieqiu

flossypurse commented 3 years ago

Thanks Dmitri, OK, so how do we "fix" that?

This repo DID exist https://github.com/temporalio/temporal-go-sdk but redirects to https://github.com/temporalio/go-sdk -

Also, how come Go Docs doesn't reflect the new state - only the old? I.E only temporal-go-sdk is shown, you can't find go-sdk there. You have to go to pkg.go.dev to find the newest version -

Thanks

On Thu, Sep 3, 2020 at 5:15 PM Dmitri Shuralyov notifications@github.com wrote:

The repository at https://github.com/temporalio/temporal-go-sdk exists.

The problem here is that godoc.org is not module aware, so it doesn't know to read the go.mod file, where it's stated that the canonical import path is go.temporal.io/sdk rather than github.com/temporalio/temporal-go-sdk.

/cc @julieqiu https://github.com/julieqiu

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/golang/gddo/issues/688#issuecomment-686810902, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIGJYBWL3UIQNCFHJOLNLJTSEAPSPANCNFSM4QWOBQIA .

dmitshur commented 3 years ago

OK, so how do we "fix" that?

There's nothing you need to do, this was fixed by making a module-aware package documentation available at pkg.go.dev, where as you said this works. Considering https://blog.golang.org/godoc.org-redirect, I don't think there's anything more to do here.