search

golang / geo

S2 geometry library in Go
Apache License 2.0
1.69k stars 182 forks source link

s1.ChordAngle: duplicated testcase #23

Closed yjh0502 closed 7 years ago

yjh0502 commented 7 years ago

There is a duplicated testcase on ChordAngle. I doubt there might be a mistake while porting source code.

https://github.com/golang/geo/blob/5747e9816367bd031622778e3e538f9737814005/s1/chordangle_test.go#L43-L44

yjh0502 commented 7 years ago

Here's another one. https://github.com/golang/geo/blob/5747e9816367bd031622778e3e538f9737814005/s1/chordangle_test.go#L66-L68

dsymonds commented 7 years ago

@rsned?

rsned commented 7 years ago

I've sent a patch to clean up the duplicate cases.

On Wed, May 31, 2017 at 11:24 PM, David Symonds notifications@github.com wrote:

@rsned https://github.com/rsned?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/golang/geo/issues/23#issuecomment-305400427, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJzBBpZRf6Hv0_hzSZvJs9nnj5FZlDuks5r_lkvgaJpZM4NsdYo .