search

golang / geo

S2 geometry library in Go
Apache License 2.0
1.69k stars 182 forks source link

s1.ChordAngle: testcase uses constant epsilon value instead of constant variables #24

Closed yjh0502 closed 7 years ago

yjh0502 commented 7 years ago

I think its better using epsilon instead of constant literal 1e-14 .

https://github.com/golang/geo/blob/5747e9816367bd031622778e3e538f9737814005/s1/chordangle_test.go#L177

dsymonds commented 7 years ago

@rsned?

rsned commented 7 years ago

Looks like we missed that one when changing to use the constant.

On Wed, May 31, 2017 at 11:24 PM, David Symonds notifications@github.com wrote:

@rsned https://github.com/rsned?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/golang/geo/issues/24#issuecomment-305400462, or mute the thread https://github.com/notifications/unsubscribe-auth/AIJzBBZ09XrcSTHdABFYXB0IkTHFqa28ks5r_lk7gaJpZM4NsfWB .