search

golang / geo

S2 geometry library in Go
Apache License 2.0
1.69k stars 182 forks source link

Add LatLng.Point and Point.LatLng functions #26

Closed jasonpfox closed 7 years ago

jasonpfox commented 7 years ago

Make downstream code more readable:

myPoint := myLatLng.Point() as opposed to myPoint := s2.PointFromLatLng(myLatLng) Same for Point to LatLng. As written, these are covered by the current test cases.

dsymonds commented 7 years ago

Thanks, but no. We don't need every possible variation of both functions and methods that do the same thing. The API here is quite large enough.

jasonpfox commented 7 years ago

Fair enough, thanks for quick response.

-- Jason Fox

jpfox@alumni.rice.edu

On Mon, Jul 3, 2017 at 6:31 PM, David Symonds notifications@github.com wrote:

Thanks, but no. We don't need every possible variation of both functions and methods that do the same thing. The API here is quite large enough.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/golang/geo/pull/26#issuecomment-312744008, or mute the thread https://github.com/notifications/unsubscribe-auth/AQY2pupVWP0QuqLzYlcEY4V3EEPQsnq3ks5sKWu0gaJpZM4OMtZL .