Closed markus-wa closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
CLAs look good, thanks!
Tests are now working with the exception of TestConvexHullPointsInsideHull
. I'm honestly not quite sure how this is happening
Thanks, but we aren't set up to accept pull requests, especially significant ones like this. We'll prioritise porting this element since it seems important for you; @rsned already has that in progress.
Ok, cool. Thanks!
This is a port of the C++ ConvexHullQuery code.
Also adds detection for reversed versions of a loop in
Loop.BoundaryEqual()
(noticed when portingTestConvexHullQuerySimplePolyline
)There are some bugs and the tests aren't working but I figure'd I'd do the PR anyway to get some feedback right away.