Closed andreweland closed 6 years ago
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!
) and we'll verify it.
I signed it!
CLAs look good, thanks!
Hi Andrew! Thanks, though we aren't really set up for taking pull requests to this project. Would you mind sending this to me internally? I can push it to this repo fairly soon after it goes in.
Thanks for shepherding the change into the internal version! Looks like you managed to get to it before I did. Thanks!
Yep, see 0bf2f2a.
The implementation and tests are a direct translation from C++, only Project() uses ChordAngle rather than Angle, in line with newer code working with distances.