golang / geo

S2 geometry library in Go
Apache License 2.0
1.69k stars 182 forks source link

ppc64le - TestPredicatesRobustSignEqualities failure due to floating point precision differences #86

Closed prashantkhoje closed 1 year ago

prashantkhoje commented 2 years ago

I ran tests on ppc64le using "go test -v ./..." command.

The TestPredicatesRobustSignEqualities fails due to floating point precision differences:

=== RUN   TestPredicatesRobustSignEqualities
    predicates_test.go:130: Testing equality for RobustSign. (0.577350269189625731058868, 0.577350269189625731058868, 0.577350269189625731058868) = (0.577350269189625842081171, 0.577350269189625842081171, 0.577350269189625842081171), got false want true
--- FAIL: TestPredicatesRobustSignEqualities (0.00s)
[root@buildvm geo]# go env
GO111MODULE=""
GOARCH="ppc64le"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="ppc64le"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/golang"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_ppc64le"
GOVCS=""
GOVERSION="go1.17.7"
GCCGO="gccgo"
GOPPC64="power8"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/root/go/src/github.com/geo/geo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build193501898=/tmp/go-build -gno-record-gcc-switches"
[root@buildvm geo]# git branch
* master
rsned commented 1 year ago

This should be fixed as part of commit https://github.com/golang/geo/commit/eee77999540a2fdb7ae874772c14223ee75e6739