golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.03k stars 17.67k forks source link

crypto/x509: TestSystemVerify failed on windows #11730

Closed chai2010 closed 9 years ago

chai2010 commented 9 years ago
go version devel +2072fc3 Thu Jul 16 00:57:45 2015 +0000 windows/amd64

--- FAIL: TestSystemVerify (0.08s)
        verify_test.go:389: #15: No expected chain matched BR/Moip Pagamentos
S.A./MOIP,SSL Blindado EV/api.moip.com.br -> GB/COMODO CA Limited//COMODO
RSA Extended Validation Secure Server CA -> GB/COMODO CA Limited//COMODO
RSA Certification Authority

FAIL
alexbrainman commented 9 years ago

@chai2010 what is your OS? From what I understand this test fails on some windows systems and has been disabled there - see https://go-review.googlesource.com/#/c/8167/ for details. Maybe it should be disabled on your too.

Alex

chai2010 commented 9 years ago

@alexbrainman The OS is Win7/64. I found this news for Win7: http://www.infoworld.com/article/2835571/microsoft-windows/microsoft-says-best-way-to-fix-botched-kb-2949927-patch-is-to-kill-it.html

alexbrainman commented 9 years ago

@chai2010 I would like to know what your OS version / service pack is. Please "go get" github.com/alexbrainman/winapi and run "go test -run=GetVersion -v" and show command's output here. Thank you.

Alex

chai2010 commented 9 years ago
C:\go\gopkg\src\github.com\alexbrainman\winapi>go test -run=GetVersion -v
=== RUN   TestGetVersionEx
--- PASS: TestGetVersionEx (0.00s)
        winapi_test.go:47: OSVERSIONINFOEX is {OSVersionInfoSize:284 MajorVersion:6
MinorVersion:1 BuildNumber:7601 PlatformId:2 CSDVersion:[83 101 114 118 105 99 101 3
2 80 97 99 107 32 49 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0
 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0] Se
rvicePackMajor:1 ServicePackMinor:0 SuiteMask:256 ProductType:1 Reserved:0}
        winapi_test.go:48: OSVERSIONINFOEX.CSDVersion is Service Pack 1
PASS
ok      github.com/alexbrainman/winapi  0.092s
alexbrainman commented 9 years ago

@chai2010 I can skip this test on your system (see https://go-review.googlesource.com/12401 for details). But that disables the test on all of our builders (and all pcs I have). So we won't know if library code is broken or not. I suggest you try and update your system instead. What do you think?

Alex

chai2010 commented 9 years ago

@alexbrainman Thanks for your work. But i dont use this pkg. And my Win7 is auto updated.

I suggest disable the test (or fix the issue) if it can't run on some system.

chai2010 commented 9 years ago

@alexbrainman We can use a build tag for all builers and all your pcs, just for Go team do test (not for Go user).