all: user-facing golang.org/x repos need to stay green

[rsc]

We need to get the subrepos green consistently for 1.5 and moving forward.

edit 2023-06-23 by @heschi: Modules that are vendored into the main release, such as net and sys, as well as user-facing libraries like tools and text, must be healthy before a release can be issued. Other modules are out of scope.

[gopherbot]

CL https://golang.org/cl/12788 mentions this issue.

[gopherbot]

CL https://golang.org/cl/12830 mentions this issue.

[gopherbot]

CL https://golang.org/cl/12832 mentions this issue.

[gopherbot]

CL https://golang.org/cl/12765 mentions this issue.

[gopherbot]

CL https://golang.org/cl/12838 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13008 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13032 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13009 mentions this issue.

[gopherbot]

CL https://golang.org/cl/12916 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13252 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13268 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13280 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13300 mentions this issue.

[gopherbot]

CL https://golang.org/cl/13695 mentions this issue.

[quentinmit]

Looking at the current status, I see several failing subrepos.

• "sync" is failing because it has no tests to run
• "arch" is failing on all the 386 platforms with #12840:

../../gopath/src/golang.org/x/arch/vendor/rsc.io/pdf/page.go:250: internal compiler error: out of fixed registers

• "exp" is failing due to missing build tags to exclude unsupported packages (linux i2c on windows, OpenGL on freebsd, etc.)
• "mobile" appears to have broken tests:

    seq_test.go:98: gomobile: toolchain partially installed, run `gomobile init`
    seq_test.go:99: failed to run gomobile bind: exit status 1

• "oauth2" is failing to find its dependencies:

cannot find package "google.golang.org/appengine"

• "term" has nothing to build

I'm not sure how useful it is to have an umbrella bug for all the different subrepos. All of these except the compiler error seem like simple fixes, however, so I'm going to tag this NeedsFix.

[gopherbot]

CL https://golang.org/cl/23318 mentions this issue.

[quentinmit]

"text" is now failing due to a2a4db7375204c22898559d3b96a748c6df96294 (upgrading tip to Unicode 9)

It looks like there's already golang.org/cl/24540 to fix it. @mpvl is there anything blocking submission of that CL?

[gopherbot]

CL https://golang.org/cl/24942 mentions this issue.

[gopherbot]

CL https://golang.org/cl/24945 mentions this issue.

[gopherbot]

CL https://golang.org/cl/24946 mentions this issue.

[gopherbot]

CL https://golang.org/cl/24944 mentions this issue.

[gopherbot]

CL https://golang.org/cl/24970 mentions this issue.

[gopherbot]

CL https://golang.org/cl/24972 mentions this issue.

[bradfitz]

Sent a bunch of CLs. Kicking down the road to Go 1.8.

[gopherbot]

CL https://golang.org/cl/30600 mentions this issue.

[gopherbot]

CL https://golang.org/cl/34274 mentions this issue.

[gopherbot]

CL https://golang.org/cl/34275 mentions this issue.

[gopherbot]

CL https://golang.org/cl/34288 mentions this issue.

[bradfitz]

Pretty green for Go 1.8.

[broady]

Looking green for 1.9.

[bradfitz]

All green for 1.10 except #23166 which is already marked for 1.10. (/cc @alandonovan) So pushing this to bug for reuse in Go 1.11.

[gopherbot]

Change https://golang.org/cl/125816 mentions this issue: godoc: fix tests on Go 1.9

[dmitshur]

The x/tools subrepo tests are currently passing on tip but failing on 1.10 and 1.9 according to https://build.golang.org/. The failures are related to the new x/tools/go/packages package have started after x/tools/cmd/callgraph began using it as of CL 128695. See https://build.golang.org/?repo=golang.org%2fx%2ftools.

/cc @alandonovan FYI.

[gopherbot]

Change https://golang.org/cl/129175 mentions this issue: cmd/callgraph: temporarily disable failing tests on go1.10

[dmitshur]

Subrepos are green on first-class ports, other than #29660 (x/tools failure on s390x) and #17538 (x/text failure on s390x).

Edit: #29660 (x/tools failure on s390x) has been resolved.

That's green enough for Go 1.12 RC 1, but we should try to fix them for final release (or reconsider what qualifies as first-class port on build.golang.org).

[andybons]

LGTM for 1.12

[gopherbot]

Change https://golang.org/cl/165797 mentions this issue: misc/android: enable many more tests on GOOS=android

[gopherbot]

Change https://golang.org/cl/171033 mentions this issue: shiny/driver/gldriver: define GL_SILENCE_DEPRECATION

[gopherbot]

Change https://golang.org/cl/171034 mentions this issue: shiny/driver/gldriver: fix 2 warnings on macOS 10.14

[bcmills]

The subrepos seem to be generally ok except on solaris-amd64-oraclerel and aix-ppc64.

(I guess this thread is probably relevant for Solaris?)

[bcmills]

I did a sweep of the dashboard for 1.13. The bad news is, there are still a lot of failures.

The good news is, many of the failures are specific to one platform or arch (openbsd-arm, illumos, and js-wasm are the most common), and a few of them are sporadic rather than consistent.

New failures include:

• x/build

  • 32838

• x/crypto

  • 32840

• x/debug

  • 32839

• x/exp

  • 32837

• x/image

  • 32835

• x/net

  • 32842

  • 32841

• x/review

  • 32836

• x/text

  • 32844

  • 32843

• x/tools

  • 32834

  • 32833

  • 32832

  • 32831

[gopherbot]

Change https://golang.org/cl/38050 mentions this issue: term: add IsTerminal func

[bcmills]

x/blog: #33940

[gopherbot]

Change https://golang.org/cl/192327 mentions this issue: dashboard: disable failing repos on misconfigured builders

[bcmills]

x/website: #33945

[bcmills]

x/website again: #33946

[bcmills]

x/tools:

• 33950

• 33951

[bcmills]

x/perf: #33952

[bcmills]

x/tools: #33956

[bcmills]

x/sys/unix, but only on go1.12 (so not a release blocker for go1.13): #33982