search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
122.7k stars 17.5k forks source link

x/crypto/ssh: TestClientUnsupportedKex : use of close network connection on FreeBSD. #15198

Open bradfitz opened 8 years ago

bradfitz commented 8 years ago

I noticed these failing ssh tests on a freebsd-amd64 trybot:

https://storage.googleapis.com/go-build-log/01360a64/freebsd-amd64-gce101_5e66e373.log

--- FAIL: TestClientAuthPublicKey (0.00s)
    client_auth_test.go:97: unable to dial remote side: ssh: handshake failed: ssh: unexpected message type 21 (expected 6)
--- FAIL: TestClientUnsupportedKex (0.00s)
    client_auth_test.go:256: got ssh: handshake failed: write tcp 127.0.0.1:30006->127.0.0.1:63686: use of closed network connection, expected 'common algorithm'
FAIL
FAIL    golang.org/x/crypto/ssh 1.024s
hanwen commented 8 years ago

unexpected message type 21 (expected 6) is the same problem as https://github.com/golang/go/issues/15066. The same problem may also cause the other error; let's wait for https://go-review.googlesource.com/#/c/21606/ to land.

hanwen commented 8 years ago

the remaining problem (use of closed network connection) is still there. Bummer.

hanwen commented 8 years ago

ugh. Seems I have broken the initial kex (again). If I add a 100ms right before requestInitalKex() in clientHandShake, all of the tests barf again. Clearly more test coverage is needed here.

bradfitz commented 8 years ago

This is still distracting us when looking for failures on build.golang.org. We need to get things not red. (that is #11811)

Can you disable this test if it's going to be flaky longer?

bradfitz commented 8 years ago

Sent https://go-review.googlesource.com/24986 to neuter the test on the build dashboard for now.

gopherbot commented 8 years ago

CL https://golang.org/cl/24986 mentions this issue.