x/build/devapp: reviews handler shows merged CLs

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

123.55k stars 17.61k forks source link

x/build/devapp: reviews handler shows merged CLs #22653

Closed bradfitz closed 6 years ago

bradfitz commented 6 years ago

https://dev.golang.org/reviews currently shows:

2017-05-22  Gustav Westling   38634 encoding/base32: add Encoding.WithPadding, StdPadding, NoPadding

But https://go-review.googlesource.com/c/go/+/38634 is merged so it shouldn't be listed as a TODO item.

andybons commented 6 years ago

Something is up with maintner’s data, since I’m using ForeachOpenCL: https://go.googlesource.com/build/+/master/devapp/reviews.go#116

bradfitz commented 6 years ago

Could you investigate? A good place to add tests (or just tests for debugging) is x/build/maintner/godata/godata_test.go, which works with the same live maintner data.

bradfitz commented 6 years ago

Oh, this got tricksy. I'm on it.

gopherbot commented 6 years ago

Change https://golang.org/cl/77690 mentions this issue: maintner: handle Gerrit ref meta changes occurring before dependent git commits