search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
124.13k stars 17.69k forks source link

crypto/tls: fix pseudo-constant mitigation for lucky 13 #27071

Open dgryski opened 6 years ago

dgryski commented 6 years ago

As detailed in the paper "Pseudo Constant Time Implementations of TLS Are Only Pseudo Secure" https://eprint.iacr.org/2018/747

josharian commented 6 years ago

cc @FiloSottile

gopherbot commented 5 years ago

Change https://golang.org/cl/170701 mentions this issue: crypto/tls: fix a minor MAC vs padding leak

gopherbot commented 5 years ago

Change https://golang.org/cl/170704 mentions this issue: crypto/tls: implement full Lucky13 countermeasures for SHA-1 CBC ciphers

gopherbot commented 5 years ago

Change https://golang.org/cl/170702 mentions this issue: crypto/tls: avoid cache-based side channels in extracting the remote MAC

gopherbot commented 5 years ago

Change https://golang.org/cl/170703 mentions this issue: crypto/sha1: add ConstantTimeSumWithData

ianlancetaylor commented 4 years ago

@FiloSottile Is there more to do here for 1.14?

odeke-em commented 4 years ago

Kindly ping @FiloSottile @katiehockman, shall we move this issue back to backlog, or is there something left for Go1.14 and then we can close it?

katiehockman commented 4 years ago

Since we're in the freeze and the RC1 has been cut, I think we should move this to the 1.15 milestone. @FiloSottile what do you think? It looks like you gave a +2 to one of the CLs early last year.

odeke-em commented 4 years ago

Punting to Go1.16 as no movement on the CLs since April 2019.

odeke-em commented 3 years ago

Punting to Go1.17.

ianlancetaylor commented 3 years ago

Moving to Backlog.