search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.55k stars 17.6k forks source link

x/build/maintner: GitHub issue becoming 404 (e.g., due to being deleted) is not reflected in model #30184

Open dmitshur opened 5 years ago

dmitshur commented 5 years ago

GitHub issue golang/go#23772 is currently 404.

If it's possible to do so in the scope of the work that maintner already does (i.e., it doesn't require going out of its way), then it should detect that and set its NotExist field gets to true.

c, err := godata.Get(context.Background())
if err != nil {
    panic(err)
}
i := c.GitHub().Repo("golang", "go").Issue(23772)

fmt.Println(i.NotExist)

// Output: false (but should be true)

/cc @bradfitz @jmdobry

(This came up from #30182.)

gopherbot commented 5 years ago

Change https://golang.org/cl/161906 mentions this issue: cmd/gopherbot: handle 404 GitHub issues in freezeOldIssues task

gopherbot commented 2 years ago

Change https://go.dev/cl/442156 mentions this issue: cmd/gopherbot: skip more deleted issues in addGitHubComment

gopherbot commented 4 months ago

Change https://go.dev/cl/593056 mentions this issue: cmd/gopherbot: handle gone issues in setMilestone too