golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.98k stars 17.67k forks source link

meta: request output of `go list -m all` in the issue template #30256

Open bcmills opened 5 years ago

bcmills commented 5 years ago

As @FiloSottile notes in https://github.com/golang/go/issues/30241#issuecomment-463829083:

I actually don't want to have to figure out if a crypto/tls internal failure is due to a replaced chacha20poly1305.

But of course the same is true for x-repo interdependencies in general: if someone is reporting an issue against, say, x/tools or x/net, it would be really helpful to know the exact version in which they found the issue, and whether any of the dependencies involved have been locally modified.

I propose that we request go list -m all alongside go env in the issue template.

(CC @thepudds @myitcv @bradfitz)

thepudds commented 5 years ago

This is probably good to do independent of the outcome of #30241.

Some people will want to remove proprietary or internal modules from the output of go list -m all, or substitute in foo or corp.example or similar. The template could attempt to briefly mention that is fine to do. Alternatively, could instead just wait to see if it confuses anyone in practice.

If you are not running with module mode enabled, go list -m all currently reports:

go list -m: not using modules

That is probably fine and understandable enough to not confuse people.

rsc commented 2 years ago

Removing from proposal process. Release team can decide on their own here; it's easy enough to change if we get it wrong.

dmitshur commented 2 years ago

This seems reasonable, @bcmills want to send a CL for this? We can try it and adjust based on experience.