search

golang / go

The Go programming language
https://go.dev
BSD 3-Clause "New" or "Revised" License
123.81k stars 17.65k forks source link

x/build/cmd/gopherbot: should not consider backport requests inside backport issues #32533

Open dmitshur opened 5 years ago

dmitshur commented 5 years ago

A backport issue should never itself be backported, so gopherbot should reject requests to backport inside such issues.

See https://github.com/golang/go/issues/32261#issuecomment-496157952 where it happened by accident and caused confusing backport-backport issues to be created.

Also happened in https://github.com/golang/go/issues/34881#issuecomment-541459267.

gopherbot commented 5 years ago

Change https://golang.org/cl/185897 mentions this issue: x/build/cmd/gopherbot: do not consider nested backport requests