x/build/env/windows: add GUI shell?

golang / go

The Go programming language

https://go.dev

BSD 3-Clause "New" or "Revised" License

123.19k stars 17.57k forks source link

x/build/env/windows: add GUI shell? #35629

Open bradfitz opened 4 years ago

bradfitz commented 4 years ago

Now that we have gomote rdp (#26090) for RDP access to our Windows buildlets, I discovered our Windows images are pretty spartan over RDP.

I guess they don't have the Windows GUI enabled?

@johnsonj, is that configurable? I assume, and Google suggests? I don't see anything in https://github.com/golang/build/blob/master/env/windows/startup.ps1 that looks like it's explicitly disabling it, at least.

johnsonj commented 4 years ago

The spartan feeling is due to the base images being mostly 'core' editions: https://github.com/golang/build/blob/master/env/windows/make.bash#L12

Switching to "Server with Desktop Experience" would be more at home in RDP. I think the images w/ just -dc- in the name are this. Can you RDP into a Server 2008 R2 machine and see if it looks better?